Photography is a funny thing sometimes. At best it's such an easy, effortless and fun process; you're in the flow state and you don't even notice how you take picture after picture that are (mostly) all good enough to be kept in your photo library, while at the worst you think no matter what you do every single picture you take sucks complete and utter monkey balls!
Fortunately I tend to be mostly on the positive side of this spectrum* , but like most photographers I have doubts sometimes about whether my photography is any good, if it is really worth it.
What I've learned through the years is that I've found two ways to combat these feelings, depending on how "bad" this feeling of suck is. Of course these are just personal anecdotes so I am not handing out a perfect solution for "photographer's block" here...I'm just writing about two methods I've used in the past. A quick search on YouTube tells me there are an endless amount of suggestions to try out...
The first option that I've applied when it is a mild case is to go out there and shoot more...to just shoot. Sure you will probably take a lot (and I do mean a lot) of bad pictures in the process but eventually you can pull through this and end up with some keepers. Now I admit It's a bit of a tall order to make yourself sling your camera bag over the shoulder when your inner self starts singing refrains on the theme "what's the point, it's probably going to suck anyway...", but if you do this you'll probably be able to pull through...if it is a mild case at least!
The second option when you're really far down on this spectrum is one that I've also tried and it's worked for me in the past. It's actually a seemingly simple one - don't use your camera. Just don't take any pictures for awhile. Read books, go to exhibitions, take walks in nature and just look at the world around you. There's bound to be something that can provide inspiration while you recharge your photographic eyes...so that once you feel the urge to shoot again you feel refreshed and inspired again...even if that might take awhile.
There's one thing that one should remember though when looking at other photographers' works in museums, online galleries and books. Don't compare their photos with all your works because their stuff has been vetted down to their very best. It's only fair that before you do your comparison you do the same. That way you can see you're probably not THAT far behind at least some of them! If you do look at your worst and compare them to their best you're not doing yourself any favors!
I've got a fairly recent example of the second option for yours truly. For almost a month I didn't have access to my DSLR since it was in the repair shop to have some components replaced and I had a hiatus from photography (at least with that machine) and now that it is back I feel a lot more eager to take pictures than I was when I handed it in to the repair guy. I don't know how long that will last, but I noticed a feeling of welcome rendezvous when I grabbed the camera again to take photos during the St:Patrick's Day festivities; as if seeing an old friend again for the first time in awhile.
* I am using the word "spectrum" in the title of this post only to describe the different extreme points in how you look at your own photography and how you can move back and forth between them. It is not meant to describe any sort of "on the spectrum" syndrome or designation like ADHD or Aspergers.